fix(dotnet) : set absolute paths on the artifacts zip#109
Closed
sriram-mv wants to merge 1 commit intoaws:developfrom
Closed
fix(dotnet) : set absolute paths on the artifacts zip#109sriram-mv wants to merge 1 commit intoaws:developfrom
sriram-mv wants to merge 1 commit intoaws:developfrom
Conversation
sriram-mv
force-pushed
the
abs_path_windows
branch
from
9fd2b5a to
54ef89b
Compare
Contributor
|
This PR does solve it but solves it at the workflow level. I submitted a PR in SAM CLI (aws/aws-sam-cli#1110) which makes sure the build_dir is always resolved. I gave a full explanation aws/aws-sam-cli#1101 (comment) for the more curious. Closing this PR in favor of the fix in SAM CLI, as it will fix it for all workflows in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sam-cli#1101
Description of changes:
With windows testing, seems to be working, putting it out there, before I investigate more.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.